ST7735 LCD+SD Reader use with SdFat library

For other supported Arduino products from Adafruit: Shields, accessories, etc.

Moderators: adafruit_support_bill, adafruit

Please be positive and constructive with your questions and comments.
Locked
harbingerx81
 
Posts: 3
Joined: Thu Dec 19, 2013 7:33 pm

ST7735 LCD+SD Reader use with SdFat library

Post by harbingerx81 »

I recently picked up the 1.8" TFT LCD with SD card reader:

http://www.adafruit.com/products/358

and I am trying to use it in conjunction with a second SD card reader:

http://www.adafruit.com/products/254

I am having issues getting the bitmap display example code from the ST7735 library working under SdFat on my Teensy 3.1.

I have downloaded the full SdFat library which is required for multiple card readers, as I discovered the SD library that is built into the IDE does not support more than one reader. I have not been able to get the bitmap example code to work however after making what I think are the required changes to account for the differences between SD and SdFat, but I am still not having any luck.

Code: Select all

#include <Adafruit_GFX.h>    // Core graphics library
#include <Adafruit_ST7735.h> // Hardware-specific library
#include <SPI.h>
#include <SD.h>

#if defined(__SAM3X8E__)
    #undef __FlashStringHelper::F(string_literal)
    #define F(string_literal) string_literal
#endif

// TFT display and SD card will share the hardware SPI interface.
// Hardware SPI pins are specific to the Arduino board type and
// cannot be remapped to alternate pins.  For Arduino Uno,
// Duemilanove, etc., pin 11 = MOSI, pin 12 = MISO, pin 13 = SCK.
#define SD_CS    4  // Chip select line for SD card
#define TFT_CS  10  // Chip select line for TFT display
#define TFT_DC   9  // Data/command line for TFT
#define TFT_RST  8  // Reset line for TFT (or connect to +5V)

//Use these pins for the shield!
//#define TFT_CS   10
//#define TFT_DC   8
//#define TFT_RST  0  // you can also connect this to the Arduino reset

Adafruit_ST7735 tft = Adafruit_ST7735(TFT_CS, TFT_DC, TFT_RST);

void setup(void) {
  Serial.begin(9600);

  Serial.print("Initializing SD card...");
  if (!SD.begin(SD_CS)) {   ///<--if (!SECURE.begin(SD_SECURE, SPI_HALF_SPEED))
    Serial.println("failed!");/// ** SdFat SECURE, and SD_SECURE pin defined
    return;
  }
  Serial.println("OK!");

  bmpDraw("parrot.bmp", 0, 0);
}

void loop() {
}

// This function opens a Windows Bitmap (BMP) file and
// displays it at the given coordinates.  It's sped up
// by reading many pixels worth of data at a time
// (rather than pixel by pixel).  Increasing the buffer
// size takes more of the Arduino's precious RAM but
// makes loading a little faster.  20 pixels seems a
// good balance.

#define BUFFPIXEL 20

void bmpDraw(char *filename, uint8_t x, uint8_t y) {

  File     bmpFile;      //////<--------------------SdFat mpFile;
  int      bmpWidth, bmpHeight;   // W+H in pixels
  uint8_t  bmpDepth;              // Bit depth (currently must be 24)
  uint32_t bmpImageoffset;        // Start of image data in file
  uint32_t rowSize;               // Not always = bmpWidth; may have padding
  uint8_t  sdbuffer[3*BUFFPIXEL]; // pixel buffer (R+G+B per pixel)
  uint8_t  buffidx = sizeof(sdbuffer); // Current position in sdbuffer
  boolean  goodBmp = false;       // Set to true on valid header parse
  boolean  flip    = true;        // BMP is stored bottom-to-top
  int      w, h, row, col;
  uint8_t  r, g, b;
  uint32_t pos = 0, startTime = millis();

  if((x >= tft.width()) || (y >= tft.height())) return;

  Serial.println();
  Serial.print("Loading image '");
  Serial.print(filename);
  Serial.println('\'');

  // Open requested file on SD card
  if ((bmpFile = SD.open(filename)) == NULL) {  ////<------if (!bmpFile.open(filename, O_READ))
    Serial.print("File not found");
    return;
  }

  // Parse BMP header
  if(read16(bmpFile) == 0x4D42) { // BMP signature
    Serial.print("File size: "); Serial.println(read32(bmpFile));
    (void)read32(bmpFile); // Read & ignore creator bytes
    bmpImageoffset = read32(bmpFile); // Start of image data
    Serial.print("Image Offset: "); Serial.println(bmpImageoffset, DEC);
    // Read DIB header
    Serial.print("Header size: "); Serial.println(read32(bmpFile));
    bmpWidth  = read32(bmpFile);
    bmpHeight = read32(bmpFile);
    if(read16(bmpFile) == 1) { // # planes -- must be '1'
      bmpDepth = read16(bmpFile); // bits per pixel
      Serial.print("Bit Depth: "); Serial.println(bmpDepth);
      if((bmpDepth == 24) && (read32(bmpFile) == 0)) { // 0 = uncompressed

        goodBmp = true; // Supported BMP format -- proceed!
        Serial.print("Image size: ");
        Serial.print(bmpWidth);
        Serial.print('x');
        Serial.println(bmpHeight);

        // BMP rows are padded (if needed) to 4-byte boundary
        rowSize = (bmpWidth * 3 + 3) & ~3;

        // If bmpHeight is negative, image is in top-down order.
        // This is not canon but has been observed in the wild.
        if(bmpHeight < 0) {
          bmpHeight = -bmpHeight;
          flip      = false;
        }

        // Crop area to be loaded
        w = bmpWidth;
        h = bmpHeight;
        if((x+w-1) >= tft.width())  w = tft.width()  - x;
        if((y+h-1) >= tft.height()) h = tft.height() - y;

        // Set TFT address window to clipped image bounds
        tft.setAddrWindow(x, y, x+w-1, y+h-1);

        for (row=0; row<h; row++) { // For each scanline...

          // Seek to start of scan line.  It might seem labor-
          // intensive to be doing this on every line, but this
          // method covers a lot of gritty details like cropping
          // and scanline padding.  Also, the seek only takes
          // place if the file position actually needs to change
          // (avoids a lot of cluster math in SD library).
          if(flip) // Bitmap is stored bottom-to-top order (normal BMP)
            pos = bmpImageoffset + (bmpHeight - 1 - row) * rowSize;
          else     // Bitmap is stored top-to-bottom
            pos = bmpImageoffset + row * rowSize;
          if(bmpFile.position() != pos) {  ///<---if(bmpFile.curPosition() != pos)
            bmpFile.seek(pos);                ///<----------bmpFile.seekSet(pos);
            buffidx = sizeof(sdbuffer); // Force buffer reload
          }

          for (col=0; col<w; col++) { // For each pixel...
            // Time to read more pixel data?
            if (buffidx >= sizeof(sdbuffer)) { // Indeed
              bmpFile.read(sdbuffer, sizeof(sdbuffer));
              buffidx = 0; // Set index to beginning
            }

            // Convert pixel from BMP to TFT format, push to display
            b = sdbuffer[buffidx++];
            g = sdbuffer[buffidx++];
            r = sdbuffer[buffidx++];
            tft.pushColor(tft.Color565(r,g,b));
          } // end pixel
        } // end scanline
        Serial.print("Loaded in ");
        Serial.print(millis() - startTime);
        Serial.println(" ms");
      } // end goodBmp
    }
  }

  bmpFile.close();
  if(!goodBmp) Serial.println("BMP format not recognized.");
}

// These read 16- and 32-bit types from the SD card file.
// BMP data is stored little-endian, Arduino is little-endian too.
// May need to reverse subscript order if porting elsewhere.

uint16_t read16(File f) {    ///<---------uint16_t read16(SdFile f)
  uint16_t result;
  ((uint8_t *)&result)[0] = f.read(); // LSB
  ((uint8_t *)&result)[1] = f.read(); // MSB
  return result;
}

uint32_t read32(File f) {   ///<-----uint16_t read16(SdFile f)
  uint32_t result;
  ((uint8_t *)&result)[0] = f.read(); // LSB
  ((uint8_t *)&result)[1] = f.read();
  ((uint8_t *)&result)[2] = f.read();
  ((uint8_t *)&result)[3] = f.read(); // MSB
  return result;
}

This shows the example code with the changes I have made (marked with "<------") to comply with the SdFat library...It compiles with no issues, but I do not get any output. I think the issue MIGHT be due to the fact that read() returns a uint16_t from the SdFat lib, but appears to return a uint8_t in the SD lib...I have tried combining things in read16() and read32() like this:

Code: Select all

uint16_t read16(SdFile f) {
  uint32_t result;
  ((uint16_t *)&result)[0] = f.read();
  ((uint16_t *)&result)[1] = f.read();
  return result;
}
to compensate, but that does not work either...Any suggestions or known issues using these two libraries together?

User avatar
paulstoffregen
 
Posts: 444
Joined: Sun Oct 11, 2009 11:23 am

Re: ST7735 LCD+SD Reader use with SdFat library

Post by paulstoffregen »

Are you using the ST7735 library from Adafruit, or my optimized version?

Adafruit's original library:
https://github.com/adafruit/Adafruit-ST7735-Library

Teensy 3.X optimized copy:
https://github.com/PaulStoffregen/Adafruit_ST7735

If you're using the optimized one, a small patch is needed to SdFat. The simplest solution might be to use the original, less optimized LCD code, to avoid this conflict.

The patch involves every place SdFat writes to SPI0_MCR. This needs to be added: "SPI_MCR_PCSIS(0x1F)". For example, change this:

Code: Select all

  SPI0_MCR = SPI_MCR_MSTR;
to this:

Code: Select all

  SPI0_MCR = SPI_MCR_MSTR | SPI_MCR_PCSIS(0x1F);

harbingerx81
 
Posts: 3
Joined: Thu Dec 19, 2013 7:33 pm

Re: ST7735 LCD+SD Reader use with SdFat library

Post by harbingerx81 »

Just managed to get back on the forums...They had my ISP blocked for a while and I needed to have them whitelist me...

I'll have to check out for optimized version sometime when I get the chance...I finally got around to checking the debug lines from the serial output and it seems what is happening with SdFat in that code is that the file pointer does not move for some reason...So every time it performs a read, it is still reading from the beginning of the file...Which seems odd to me, because I expected it to behave more like the SD library in that regard...Is there some setting or parameter that I need to change to make this the default after a .read(), or does SdFat require me to manually track and set the file position?

User avatar
paulstoffregen
 
Posts: 444
Joined: Sun Oct 11, 2009 11:23 am

Re: ST7735 LCD+SD Reader use with SdFat library

Post by paulstoffregen »

I do not know. I really haven't used SdFat much. I've always just used the SD library, which is based on a very old version of SdFat.

deseipel
 
Posts: 14
Joined: Mon Oct 31, 2011 2:24 pm

Re: ST7735 LCD+SD Reader use with SdFat library

Post by deseipel »

Can anyone confirm that sdfat works with the 1.8" TFT w/card reader?

Locked
Please be positive and constructive with your questions and comments.

Return to “Other Arduino products from Adafruit”