Just submitted a patch to LiquidCrystal library to support the Arduino Due

EL Wire/Tape/Panels, LEDs, pixels and strips, LCDs and TFTs, etc products from Adafruit

Moderators: adafruit_support_bill, adafruit

Please be positive and constructive with your questions and comments.
Locked
User avatar
jockm
 
Posts: 65
Joined: Mon May 13, 2013 11:43 pm

Just submitted a patch to LiquidCrystal library to support the Arduino Due

Post by jockm »

I am doing a project on the Arduino Due that needed to use a I2C LCD, only to discover that the code doesn't compile on the Due. I dove in and discovered that the changes needed were minimal: adding a conditional #define for _BV(), and removing the #include for pgmspace.h

I have submitted a pull request on github, and hopefully Adafruit will incorporate it soon. I am sure I am not the only Due owner who wanted to do that :D

In the mean time, those interested can get my fork here: https://github.com/jockm/LiquidCrystal

User avatar
adafruit_support_rick
 
Posts: 35092
Joined: Tue Mar 15, 2011 11:42 am

Re: Just submitted a patch to LiquidCrystal library to support the Arduino Due

Post by adafruit_support_rick »

Thanks! :D

User avatar
jockm
 
Posts: 65
Joined: Mon May 13, 2013 11:43 pm

Re: Just submitted a patch to LiquidCrystal library to support the Arduino Due

Post by jockm »

Out of curiosity, do you guys have any idea if/when this pull request (or at least the trivial change needed) will be accepted?

With the recent blog posts about compatibility it seems like this is a quick win to allow the use of I2C LiquidCrystal on the Due and most other non AVR based Arduino systems.

adafruit
 
Posts: 12151
Joined: Thu Apr 06, 2006 4:21 pm

Re: Just submitted a patch to LiquidCrystal library to support the Arduino Due

Post by adafruit »

Hi there, sorry we didn't see it! We'll ask someone to test and pull ASAP

User avatar
jockm
 
Posts: 65
Joined: Mon May 13, 2013 11:43 pm

Re: Just submitted a patch to LiquidCrystal library to support the Arduino Due

Post by jockm »

Excellent! Thank you very much.

User avatar
jockm
 
Posts: 65
Joined: Mon May 13, 2013 11:43 pm

Re: Just submitted a patch to LiquidCrystal library to suppo

Post by jockm »

And...?

User avatar
adafruit_support_rick
 
Posts: 35092
Joined: Tue Mar 15, 2011 11:42 am

Re: Just submitted a patch to LiquidCrystal library to suppo

Post by adafruit_support_rick »

Merged!
Sorry it fell through the cracks like that.

User avatar
jockm
 
Posts: 65
Joined: Mon May 13, 2013 11:43 pm

Re: Just submitted a patch to LiquidCrystal library to suppo

Post by jockm »

Awesome! Thank you so very much.

Locked
Please be positive and constructive with your questions and comments.

Return to “Glowy things (LCD, LED, TFT, EL) purchased at Adafruit”